remove code smells

Signed-off-by: Jeromy Cannon <[email protected]>
hashgraph · Sep 22, 2023 · 44754c1 · 44754c1
1 parent d068f26
commit 44754c1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/fullstack-base-api/src/test/java/com/hedera/fullstack/base/api/test/util/FileUtilsTest.java b/fullstack-base-api/src/test/java/com/hedera/fullstack/base/api/test/util/FileUtilsTest.java
@@ -23,12 +23,12 @@
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 
-public class FileUtilsTest {
+class FileUtilsTest {
     @Test
     @DisplayName("Test getWorkingPath")
     void testGetWorkingPath() {
         Path currentPath = FileUtils.getWorkingPath().toAbsolutePath();
         assertThat(currentPath.getName(currentPath.getNameCount() - 2).toString())
-                .isEqualTo("fullstack-base-api");
+                .hasToString("fullstack-base-api");
     }
 }
diff --git a/...stack-gradle-plugin/src/main/java/com/hedera/fullstack/gradle/plugin/FullstackPlugin.java b/...stack-gradle-plugin/src/main/java/com/hedera/fullstack/gradle/plugin/FullstackPlugin.java
@@ -21,5 +21,7 @@
 
 public class FullstackPlugin implements Plugin<Project> {
     @Override
-    public void apply(Project project) {}
+    public void apply(Project project) {
+        // currently no implementation is needed
+    }
 }
diff --git a/...-gradle-plugin/src/main/java/com/hedera/fullstack/gradle/plugin/HelmInstallChartTask.java b/...-gradle-plugin/src/main/java/com/hedera/fullstack/gradle/plugin/HelmInstallChartTask.java
@@ -19,9 +19,7 @@
 import com.hedera.fullstack.helm.client.HelmClient;
 import com.hedera.fullstack.helm.client.HelmClientBuilder;
 import com.hedera.fullstack.helm.client.model.Chart;
-import com.hedera.fullstack.helm.client.model.chart.Release;
 import com.hedera.fullstack.helm.client.model.install.InstallChartOptionsBuilder;
-import javax.inject.Inject;
 import org.gradle.api.DefaultTask;
 import org.gradle.api.provider.Property;
 import org.gradle.api.provider.SetProperty;
@@ -68,11 +66,6 @@ public abstract class HelmInstallChartTask extends DefaultTask {
     // TODO: enhance to support multiple values files
     public abstract SetProperty<String> getValues();
 
-    @Inject
-    public HelmInstallChartTask() {
-        super();
-    }
-
     @TaskAction
     void installChart() {
         HelmClientBuilder helmClientBuilder = HelmClient.builder();
@@ -90,8 +83,7 @@ void installChart() {
         if (getValues().isPresent()) {
             optionsBuilder.values(getValues().get());
         }
-        // TODO: release is not used here
-        Release release = helmClient.installChart(
+        helmClient.installChart(
                 getRelease().getOrNull(),
                 new Chart(getChart().getOrNull(), getRepo().getOrNull()),
                 optionsBuilder.build());