-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to wgpu 0.10 #32
Conversation
The PR was still in draft status. Do you want to add something? Or should I merge it? |
I'm experiencing some issues with the rendered frames, they are way too dark (see https://github.com/niklaskorz/linon/). Not entirely sure if it's an issue in my project or in the egui wgpu backend. Still investigating, so I put it in draft mode for now. |
I'm not using egui anymore, so I can't assist you with debugging. I'm just maintaining the PRs and the release process. |
What does it do when you change: let mut sc_desc = wgpu::SwapChainDescriptor {
usage: wgpu::TextureUsage::RENDER_ATTACHMENT,
format: OUTPUT_FORMAT,
width: size.width as u32,
height: size.height as u32,
present_mode: wgpu::PresentMode::Mailbox,
}; let mut sc_desc = wgpu::SwapChainDescriptor {
usage: wgpu::TextureUsage::RENDER_ATTACHMENT,
format: adapter.get_swap_chain_preferred_format(&surface).unwrap(),
width: size.width as u32,
height: size.height as u32,
present_mode: wgpu::PresentMode::Mailbox,
}; In the example? |
The outcome is the same, unfortunately. |
@niklaskorz https://github.com/hasenbanck/egui_wgpu_backend/blob/master/src/shader/egui.wgsl#L18 |
That's it! Thanks a lot @Gordon-F Ready to merge :) @hasenbanck |
LGTM |
Updates wgpu dependency to 0.10 and fixes breaking changes in the code.