Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version mismatch in @ngrx/store package. #352

Closed
wants to merge 1 commit into from

Conversation

ItamarGronich
Copy link
Contributor

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Docs related changes
[ ] Other... Please describe:

Link to the open issue:

Other information:
ngrx/platform#170
ngrx/platform#264

- Versions 4.0.0 - 4.0.3 have a bug related to setting up metaReducers
  (ngrx/platform#264).
- We should include a package-lock.json top prevent those kinds of
  things
- package-lock.json will make sure we all have the same versions of
  everything.
@ItamarGronich ItamarGronich requested a review from nirgn975 August 24, 2017 19:25
@codecov-io
Copy link

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   55.29%   55.29%           
=======================================
  Files          54       54           
  Lines        1049     1049           
  Branches       35       35           
=======================================
  Hits          580      580           
  Misses        443      443           
  Partials       26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e77ead...55da6d4. Read the comment docs.

@ItamarGronich
Copy link
Contributor Author

@nirgn975 This is ready for review. I actually need this to continue my work on #351 so i'll merge this into that pr right now, and when it will later merge - America will be great agian.

@nirgn975
Copy link
Member

nirgn975 commented Aug 25, 2017

There is not reason the keep metaReducers, we use Redux devTools chrome extension. So I remove them and upgrade ngrx to 4.0.7.

I'm closing this PR, re-roll from master in #351

@nirgn975 nirgn975 closed this Aug 25, 2017
@nirgn975 nirgn975 deleted the FIX-ngrx-store-version branch October 23, 2017 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants