Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove css override of white background on darkmode #815

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

YuvalMasada
Copy link
Collaborator

@NoamGaash
Fix description:
Remove css override for white background that makes text unreadable while on Darkmode

How to test:

  1. Go Dashboard/Gap patterns page
  2. select start date that is earlier than end date.
  3. A new Alert message should appear above the dates picker with validation error.
  4. Change to Dark mode and check that background of the validation error alert is not white and that the message is clear.

@NoamGaash
Copy link
Member

Thank you!

@YuvalMasada
Copy link
Collaborator Author

@NoamGaash
Do you know why this PR is not finishing the checks?
The scm/applitools is pending.
If there is something that I can do please tell me.

@NoamGaash
Copy link
Member

@YuvalMasada when saving new baselines in the main branch, Eyes performs a conflicts check. I've probably misconfigured something, but the potential conflicts doesn't concern me. feel free to merge

@YuvalMasada YuvalMasada merged commit 9813128 into main Jun 19, 2024
18 of 19 checks passed
@YuvalMasada YuvalMasada deleted the fix/darkmode-on-date-validation-error-messages branch June 19, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants