Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use Only Relevant Routes #244

Merged

Conversation

ArkadiK94
Copy link
Collaborator

Description

How: filter the routes date when we get them from back-end

Why: it fixes stop duplication and don't use yesterday routes

Solves issue #134 from front. You still should change the back-end or not, up to you.

  • I read that you discussed about changing the back-end so it will not send the routes of yesterday but as I see it, we should have a "protection in the front" in case the back-end sends not relevant routes like it happens now :)

screenshots

Before:
Recording.2023-11-25.165458.mp4

After:

Recording.2023-11-25.165323.mp4

How: filter the routes date when we get them from backend
Why: it fixes stop duplication and don't use yesterday routes
Copy link

netlify bot commented Nov 25, 2023

Deploy Preview for astonishing-pothos-5f81bd ready!

Name Link
🔨 Latest commit dbcfad5
🔍 Latest deploy log https://app.netlify.com/sites/astonishing-pothos-5f81bd/deploys/65620da57c2eba0008a17102
😎 Deploy Preview https://deploy-preview-244--astonishing-pothos-5f81bd.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NoamGaash NoamGaash linked an issue Nov 25, 2023 that may be closed by this pull request
@ArkadiK94 ArkadiK94 changed the title [Fix] Use Only Relevant Routes fix: Use Only Relevant Routes Nov 26, 2023
@ArkadiK94 ArkadiK94 merged commit c32d806 into hasadna:main Nov 26, 2023
13 checks passed
@ArkadiK94 ArkadiK94 deleted the fix/unwanted-routes-day-and-stop-duplication branch November 26, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicated bus stations at stations list
2 participants