[master]: Apache HttpClient will set Host header automatically #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I will check this on my system and will soon release a new version of cups4j, as this is a bug fix many people will need. |
|
Thanks for merging the change @harwey. The release will be generated automatically? Thanks. |
|
@harwey Can you publish this fix with 0.7.8 to the maven repository? |
|
@harwey Could you please release this fix ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of this change is to remove the configurable host header via properties. After removing this Apache HttpClient will calculate this header automatically. I have tested this enabling Apache HttpClient logs with this result:
2020/11/19 08:46:40:487 CET [DEBUG] headers - http-outgoing-0 >> Content-Type: application/ipp
2020/11/19 08:46:40:487 CET [DEBUG] headers - http-outgoing-0 >> Host: localhost:631
2020/11/19 08:46:40:487 CET [DEBUG] headers - http-outgoing-0 >> Connection: Keep-Alive
Thanks!