Stub out harvester-node-manager-webhook #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bk201
reviewed
Dec 20, 2023
added 5 commits
December 20, 2023 11:02
Signed-off-by: Connor Kuehl <[email protected]>
Signed-off-by: Connor Kuehl <[email protected]>
Signed-off-by: Connor Kuehl <[email protected]>
Signed-off-by: Connor Kuehl <[email protected]>
Signed-off-by: Connor Kuehl <[email protected]>
Vicente-Cheng
approved these changes
Dec 21, 2023
bk201
reviewed
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: harvester/harvester#4710
Related to: harvester/harvester#4709
This PR adds the webhook boilerplate from the sample repo[1]. It registers mutation and validation admission handlers for the recently-merged CloudInit CR but they are stubbed out to prevent the creation of those resources until the business logic is added in a following PR.
[1] https://github.com/harvester/webhook-sample