-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add content about vmimage backup #613
base: main
Are you sure you want to change the base?
Conversation
|
docs/vm/backup-restore.md
Outdated
You must manually configure the virtual machine images with the same name on the new cluster first, otherwise the virtual machines will be failed to recover. | ||
|
||
::: | ||
Harvester will handle VMImage data automatically. If a volume is based on a VMImage and there is a backup for it, Harvester will automatically sync the VMImage to backup target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's handled automatically, should we remove the section too?
#### Upload the same VM images to a new cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest changing VMImage
to VM image for consistency across the document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. I addressed all comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian <[email protected]>
5fbcfb0
to
eadf877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last commit brought back some wording issues.
EOF | ||
``` | ||
Harvester automatically handles VM image data. If a volume is based on a VM image with a backup, Harvester automatically syncs the VM image with the backup target. | ||
In a new cluster, it the VMbackup is restored to a new VM, Harvester will automatically create the VM image from the backup target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a new cluster, it the VMbackup is restored to a new VM, Harvester will automatically create the VM image from the backup target. | |
In a new cluster, if the VM backup is restored to a new VM, Harvester automatically creates the VM image from the backup target. |
harvester/harvester#2237