fix: memoryLimit doesn't work in for tag, #776

harttle · Dec 22, 2024 · 2af297f · 2af297f
1 parent d61855b
commit 2af297f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/docs/package.json b/docs/package.json
@@ -3,7 +3,7 @@
   "version": "0.0.0",
   "private": true,
   "hexo": {
-    "version": "5.4.0"
+    "version": "7.3.0"
   },
   "scripts": {
     "build": "hexo generate",

diff --git a/docs/themes/navy/source/js/main.js b/docs/themes/navy/source/js/main.js
@@ -60,7 +60,10 @@
   /* global liquidjs, ace */
   if (!location.pathname.match(/playground.html$/)) return;
   updateVersion(liquidjs.version);
-  const engine = new liquidjs.Liquid();
+  const engine = new liquidjs.Liquid({
+    memoryLimit: 1e5,
+    renderLimit: 1e5
+  });
   const editor = createEditor('editorEl', 'liquid');
   const dataEditor = createEditor('dataEl', 'json');
   const preview = createEditor('previewEl', 'html');

diff --git a/src/render/expression.ts b/src/render/expression.ts
@@ -67,6 +67,7 @@ export function evalQuotedToken (token: QuotedToken) {
 function * evalRangeToken (token: RangeToken, ctx: Context) {
   const low: number = yield evalToken(token.lhs, ctx)
   const high: number = yield evalToken(token.rhs, ctx)
+  ctx.memoryLimit.use(high - low + 1)
   return range(+low, +high + 1)
 }
 

diff --git a/test/e2e/issues.spec.ts b/test/e2e/issues.spec.ts
@@ -524,4 +524,9 @@ describe('Issues', function () {
     const result = engine.parseAndRenderSync(`\n{{ "foo" | pos }}`)
     expect(result).toEqual('\n[2,12] foo')
   })
+  it("memoryLimit doesn't work in for tag #776", () => {
+    const engine = new Liquid()
+    const tpl = `{% for i in (1..1000000000) %} {{'a'}} {% endfor %}`
+    expect(() => engine.parseAndRenderSync(tpl)).toThrow(/memory out/)
+  })
 })