Fix connect info for mobile app testing. (nightwatchjs#3577)

harshit-bs · Mar 16, 2023 · 370c1ec · 370c1ec
1 parent 9cd9735
commit 370c1ec
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/lib/transport/selenium-webdriver/index.js b/lib/transport/selenium-webdriver/index.js
@@ -316,9 +316,15 @@ class Transport extends BaseTransport {
     }
 
     if (this.outputEnabled) {
-      const {platform, browserVersion, platformVersion, browserName} = sessionInfo;
+      const {platform, browserVersion, platformVersion, browserName, appId} = sessionInfo;
+
+      const appName = appId.split('.').pop() || browserName;
+      const appVersion = browserVersion && ` (${browserVersion})`;
+      const platName = platform.toUpperCase();
+      const platVersion = platformVersion && ` (${platformVersion})`;
+
       // eslint-disable-next-line no-console
-      console.info(`  Using: ${colors.light_blue(browserName)} ${colors.brown('(' + (browserVersion) + ')')} on ${colors.cyan(platform.toUpperCase() + (platformVersion ? (' (' + platformVersion + ')') : ''))}.\n`);
+      console.info(`  Using: ${colors.light_blue(appName)}${colors.brown(appVersion)} on ${colors.cyan(platName + platVersion)}.\n`);
     }
   }
 

diff --git a/lib/transport/selenium-webdriver/session.js b/lib/transport/selenium-webdriver/session.js
@@ -27,6 +27,7 @@ module.exports = class Session {
     const platformVersion = sessionCapabilities.get('platformVersion') || '';
     const browserName = sessionCapabilities.getBrowserName();
     const browserVersion = sessionCapabilities.getBrowserVersion() || sessionCapabilities.get('version') || '';
+    const appId = sessionCapabilities.get('appPackage') || sessionCapabilities.get('bundleId') || '';
 
     const executor = await this.driver.getExecutor();
     const elementKey = executor.w3c ? Session.WEB_ELEMENT_ID : 'ELEMENT';
@@ -38,7 +39,8 @@ module.exports = class Session {
         platform,
         platformVersion,
         browserName,
-        browserVersion
+        browserVersion,
+        appId
       },
       capabilities: Session.serializeCapabilities(sessionCapabilities)
     };