Skip to content

Commit

Permalink
Add missing types for AwsSigv4SignerOptions.service (opensearch-proje…
Browse files Browse the repository at this point in the history
…ct#377)

* Add missing types for AwsSigv4SignerOptions.service

Signed-off-by: magoz <[email protected]>

* update changelog with Add missing types for AwsSigv4SignerOptions.service

Signed-off-by: magoz <[email protected]>

* fix: service is optional

Signed-off-by: magoz <[email protected]>

---------

Signed-off-by: magoz <[email protected]>
  • Loading branch information
magoz authored Feb 14, 2023
1 parent 38e0e1a commit c44cc1c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
### Deprecated
### Removed
### Fixed
- Added missing types for AwsSigv4SignerOptions.service ([#377](https://github.com/opensearch-project/opensearch-js/pull/377))


### Security
- [CVE-2022-25912] Bumps simple-git from 3.4.0 to 3.15.0 ([#341](https://github.com/opensearch-project/opensearch-js/pull/341))

Expand Down
1 change: 1 addition & 0 deletions lib/aws/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { OpenSearchClientError } from '../errors';
interface AwsSigv4SignerOptions {
getCredentials?: () => Promise<Credentials>;
region: string;
service?: 'es' | 'aoss';
}

interface AwsSigv4SignerResponse {
Expand Down

0 comments on commit c44cc1c

Please sign in to comment.