Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make help popup not editable and close it on BufLeave #355

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Make help popup not editable and close it on BufLeave #355

merged 1 commit into from
Sep 5, 2024

Conversation

EpiCanard
Copy link

Hello,

This PR make the help popup not editable by calling switch_can_edit_buf with false.
It also add a popup listener to automatically close the help popup when the buffer is leaved.

@harrisoncramer harrisoncramer changed the base branch from main to develop September 5, 2024 16:30
@harrisoncramer harrisoncramer changed the base branch from develop to main September 5, 2024 17:04
@harrisoncramer harrisoncramer changed the base branch from main to develop September 5, 2024 17:04
@harrisoncramer
Copy link
Owner

Thank you for the contribution! Looks good!

@harrisoncramer harrisoncramer merged commit 8d1d351 into harrisoncramer:develop Sep 5, 2024
6 checks passed
@harrisoncramer harrisoncramer mentioned this pull request Sep 5, 2024
Merged
harrisoncramer added a commit that referenced this pull request Sep 5, 2024
@harrisoncramer
Popup and Keymap Updates (#356)
6500ef1 
feat: Enable always jumping to discussion tree (#352)
feat: Enables motions for easier range selection when creating comments/suggestions (e.g. s3j, c3j) (#353)
fix: Makes help popup not editable and close it on BufLeave (#355)

This is a #MINOR release
@harrisoncramer harrisoncramer mentioned this pull request Sep 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EpiCanard @harrisoncramer