New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Discussion tree highlighting #342

Merged

harrisoncramer merged 4 commits into harrisoncramer:develop from jakubbortlik:fix-discussion-tree-highlighting

Aug 9, 2024

Collaborator

jakubbortlik commented Aug 9, 2024

#339 introduced some regressions in discussion tree highlighting. This PR fixes:

expander highlighting in sub-nodes
highlighting of usernames with dots (e.g., @name.surname)
separate highlighting for mentions (different from GitlabUsername)

jakubbortlik added 4 commits

August 9, 2024 02:03


          Fix: Highlight expanders in sub-nodes

95438d0


          Fix: Allow dot in username

e6cf91e


          Style: Use single quotes according to vint linter

a2f1b54


          Fix: Restore separate hightlighting for mentions

c1de7af

Owner

harrisoncramer commented Aug 9, 2024 •

edited

Loading

🚀 🚀 🚀

Thank you!!

harrisoncramer merged commit 221a3fa into harrisoncramer:develop

6 checks passed

jakubbortlik deleted the fix-discussion-tree-highlighting branch

September 6, 2024 05:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet