Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove API calls on Discussion Close #328

Merged
merged 4 commits into from
Jul 6, 2024
Merged

Fix: Remove API calls on Discussion Close #328

merged 4 commits into from
Jul 6, 2024

Conversation

harrisoncramer
Copy link
Owner

@harrisoncramer harrisoncramer commented Jul 5, 2024 •
edited
Loading

The toggle was calling these APIs on both opening and closing, which was causing slowness.

harrisoncramer and others added 3 commits June 26, 2024 07:30
@harrisoncramer
Release (#313)
3c9d95d 
* Fix docs: choose_merge_request's open_reviewer default value is true (#316)
* Fix: Only set autocommands for select popups (#315)
* Docs: Small improvements to README and docs
* Feat: Add branch info to choose_merge_request menu (#318)

This is a PATCH release.
@harrisoncramer
Release (#327)
dc70c97 
Fix: Only set autocommands for select popups (#315)
Docs: Small improvements to README and docs
Feat: Add branch info to choose_merge_request menu (#318)
Chore: Add heart emoji (#323)
Feat: Add highlight for mentions (#324)
Fix: Do Not Error w/Out Buffer Content (#325)

This is a MINOR release.
@harrisoncramer
remove api calls on discussion close
fa83476
@harrisoncramer harrisoncramer changed the base branch from main to develop July 5, 2024 02:17
@harrisoncramer harrisoncramer marked this pull request as ready for review July 5, 2024 02:17
@harrisoncramer harrisoncramer mentioned this pull request Jul 5, 2024
Closed
3 tasks
@harrisoncramer harrisoncramer merged commit 85dc29c into develop Jul 6, 2024
6 checks passed
@harrisoncramer harrisoncramer mentioned this pull request Jul 6, 2024
Merged
harrisoncramer added a commit that referenced this pull request Jul 6, 2024
@harrisoncramer
Release (#330)
95dcc41 
Fix diagnostic position when sha changes (#299)
Fix: Remove API calls on Discussion Close (#328)
Chore: Remove root node type (#329)

This is a PATCH release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@harrisoncramer