Fix: Ranged comment signs not showing #305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #302.
This PR also makes it possible to hide the diagnostic sign (e.g.,
I
if the diagnostic level is "INFO") - this makes the diagnostic range icons better aligned. The default behaviour of the plugin does not change, i.e., the diagnostic signs are shown.I've noticed one small bug that existed already with nvim 0.9, if some signs overlap, the
GitlabComment
icons are hidden by theGitlabRange
icons the first time the signs are placed. This is because for some reason, this line inlua/gitlab/indicators/signs.lua:33
does not return any already placed signs:On subsequent runs (e.g., when jumping to a diagnostic or when switching files in the review), the overlapping signs are placed correctly and the
GitlabComment
sign takes precedence. If I found the reason for this behaviour I would like to fix it in this PR, but I haven't been successful so far. Maybe it has to do with calling avim
function inside alua
script.Regarding the small modifications of the documentation, there are still some inconsistencies between the default setup settings and the ones described in the README and docs (e.g.,
skip_old_revision_discussion
), but right now I don't have the time to fix those. Have you considered keeping the settings in let's say just two places? The README could maybe only contain a link to the docs. It would be easier to maintain consistency.