Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correcting some problem with review mode #225

Merged

Conversation

ElricleNecro
Copy link
Contributor

Trying to fix some problem in the review command of the plugin, as describe in this github discussion.

It concern mainly the following problems:

  • Error executing lua: Vim:E5300: Expected a Number or a String
    stack traceback:
      [C]: in function 'bufnr'
      ...lazy/gitlab.nvim/lua/gitlab/actions/discussions/init.lua:456: in function 'jump_to_file'
      ...lazy/gitlab.nvim/lua/gitlab/actions/discussions/init.lua:832: in function <...lazy/gitlab.nvim/lua/gitlab/actions/discussions/init.lua:830>
    
  • E5108: Error executing lua: ...lazy/gitlab.nvim/lua/gitlab/actions/discussions/init.lua:467: Cursor position outside buffer
    stack traceback:
    	[C]: in function 'nvim_win_set_cursor'
    	...lazy/gitlab.nvim/lua/gitlab/actions/discussions/init.lua:467: in function 'jump_to_file'
    	...lazy/gitlab.nvim/lua/gitlab/actions/discussions/init.lua:834: in function <...lazy/gitlab.nvim/lua/gitlab/actions/discussions/init.lua:832>
    

@harrisoncramer
Copy link
Owner

harrisoncramer commented Mar 28, 2024

Thank you for noticing this, it was a regression that was introduced after a recent major refactor of the plugin! I don't often use these keybindings and hadn't noticed.

@harrisoncramer harrisoncramer added the bug Something isn't working label Mar 29, 2024
refactoring a bit the methods to fit the review.
@harrisoncramer harrisoncramer merged commit 12c4acb into harrisoncramer:main Apr 8, 2024
6 checks passed
harrisoncramer added a commit that referenced this pull request Apr 8, 2024
@harrisoncramer harrisoncramer mentioned this pull request Apr 8, 2024
@ElricleNecro ElricleNecro deleted the fix/review-comments branch September 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants