Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Calculate new line in ranged comment after all hunks correctly #211

Merged
merged 2 commits into from
Mar 4, 2024
Merged

fix: Calculate new line in ranged comment after all hunks correctly #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c73d229
Fix: Fixes Misspelling In Diagnostics Settings Check (#210)
harrisoncramer Mar 3, 2024
3c4e29f
include net changes
harrisoncramer Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lua/gitlab/hunks/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ M.calculate_matching_line_new = function(old_sha, new_sha, file_path, line_numbe
end

-- TODO: Possibly handle lines that are out of range in the new files
return line_number
return line_number + net_change + 1
end

return M
2 changes: 1 addition & 1 deletion lua/gitlab/indicators/signs.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ local severity_map = {
---@param diagnostics Diagnostic[]
---@param bufnr number
M.set_signs = function(diagnostics, bufnr)
if not state.settings.discussion_sign.enabled then
if not state.settings.discussion_signs.enabled then
return
end

Expand Down
Loading