Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Create Merge Request #149

Merged
merged 27 commits into from
Dec 19, 2023
Merged

Feat: Create Merge Request #149

merged 27 commits into from
Dec 19, 2023

Conversation

harrisoncramer
Copy link
Owner

@harrisoncramer harrisoncramer commented Dec 17, 2023

This MR will allow you to create a merge request for the current branch without leaving Neovim.

This was previously deferred as a feature since the glab CLI tool already supports this, however, being able to do this inside of the plugin is core to resolving/merging/managing MRs.

This required a slight refactor of the Go server, which previously made a call to get the MR info at startup every time. Since the MR will not necessarily be created now at startup, we have moved that call into a middleware that's called prior to every route that requires the data, assuming that the mergeId property has not already been initialized in the client state.

The refactor therefore moves all routes that require the additional merge request call under the /mr route prefix.

@harrisoncramer
Copy link
Owner Author

This MR will address #41

@harrisoncramer harrisoncramer marked this pull request as ready for review December 18, 2023 04:14
@harrisoncramer harrisoncramer merged commit 37a5384 into main Dec 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant