Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoints are duplicated when set before the debugger attaches #9

Open
StephenBloomquist opened this issue Dec 31, 2016 · 4 comments
Labels

Comments

@StephenBloomquist
Copy link
Contributor

The file paths which get stored with the breakpoints have a lowercase drive letter when set pre-attach.
Breakpoints set post-attach have uppercase drive letters.
The file path that's compared against in getBreakpointsForFile() has an uppercase drive letter.
This causes the string compare in getBreakpointsForFile() to fail on breakpoints set pre-attach.

Ultimately the duktape debugger still sees these breakpoints even though vscode doesn't and acts on them accordingly (there's also no way to clear them since vscode doesn't see them).

Temp solution on my fork is just doing .toLowerCase() during the comparison but it's obviously not optimal.

@harold-b
Copy link
Owner

Thanks for notifying me, I'll have a look an issue a fix as soon as I can.

@StephenBloomquist
Copy link
Contributor Author

Interesting. I can't seem to reproduce this anymore with either the current version of your debugger or the previous. Last time I experienced it was the 22nd of December.

@StephenBloomquist
Copy link
Contributor Author

Ah, I see what happened now. I went back to the original project folder that I first used the debugger for and the problem returned. The issue is me entering a full path for the localRoot config variable, rather than using ${workspaceRoot}. I wrote "C:/Users/..." and that's what's making the difference with the drive letter.

@andrewrch
Copy link
Collaborator

@StephenBloomquist Quite a long time since this issue was created. Given the comment above can I assume this is resolved or do you still have issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants