Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gateway): added presence caching, marking events as complete! #45

Merged
merged 4 commits into from
Dec 2, 2020
Merged

feat(gateway): added presence caching, marking events as complete! #45

merged 4 commits into from
Dec 2, 2020

Conversation

DjDeveloperr
Copy link
Member

This PR introduces

  • Presence caching, using new GuildPresencesManager
  • Guild#presences was changed.
  • guildMembersChunk should now cache presences too.
  • presenceUpdate event was added.
  • Added types for previously added events, now all done.

With this PR, all gateway events are complete 😄

@Helloyunho
Copy link
Member

Hell yeah lets goo

@AkiaCode AkiaCode linked an issue Dec 2, 2020 that may be closed by this pull request
TODO: Make a Full Featured Gateway #11
Closed
45 tasks
Helloyunho
Helloyunho approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! I'm happy that we finished handling every event!

@Helloyunho Helloyunho merged commit 78c86a9 into harmonyland:main Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helloyunho Helloyunho Helloyunho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TODO: Make a Full Featured Gateway
2 participants
@DjDeveloperr @Helloyunho