Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Inconsistent from field Hash Calculation in Different API Versions #2 #4582

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix: Inconsistent from field Hash Calculation in Different API Versions #2 #4582

merged 1 commit into from
Dec 7, 2023

Conversation

adsorptionenthalpy
Copy link
Contributor

Issue

This is a followup to #4581 where the hash calculation resulted in an incorrect from address when querying the eth api.
This corrects the GetTransactionReceipt path that also incorported tx.ConvertEth() so that receipts will also show the correct from address.

@adsorptionenthalpy adsorptionenthalpy changed the title Feature/het104 12523 Fix: Inconsistent from field Hash Calculation in Different API Versions #2 Dec 6, 2023
@adsorptionenthalpy adsorptionenthalpy changed the base branch from main to dev December 6, 2023 05:29
@adsorptionenthalpy adsorptionenthalpy marked this pull request as draft December 6, 2023 23:41
@adsorptionenthalpy adsorptionenthalpy marked this pull request as ready for review December 7, 2023 14:46
@adsorptionenthalpy adsorptionenthalpy merged commit 2001b34 into dev Dec 7, 2023
4 checks passed
@adsorptionenthalpy adsorptionenthalpy deleted the feature/HET104-12523 branch December 7, 2023 14:46
@adsorptionenthalpy adsorptionenthalpy mentioned this pull request Dec 7, 2023
Closed
MaxMustermann2 added a commit to MaxMustermann2/harmony that referenced this pull request Dec 14, 2023
@MaxMustermann2
Revert harmony-one#4582: RPC Receipt Fix
9bfa0c1 
This reverts commit 2001b34, reversing
changes made to 29c6249. The change is
made because `eth_getTransactionReceipt` should respond with `0x`
addresses and never their bech32 equivalents.
@MaxMustermann2 MaxMustermann2 mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diego1q2w diego1q2w diego1q2w approved these changes

@ONECasey ONECasey Awaiting requested review from ONECasey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adsorptionenthalpy @diego1q2w