Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kill_node script #4463

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Fix kill_node script #4463

merged 1 commit into from
Jul 11, 2023

Conversation

GheisMohammadi
Copy link
Contributor

Issue

The script to kill harmony process doesn't work. This is the error given from Travis logs:

pkill: pattern that searches for process name longer than 15 characters will result in zero matches
Try `pkill -f' option to match against the complete command line.

The issue is the pattern for pkill command can't be longer than 15 characters. This PR uses an array rather than a long pattern to address the issue.

@GheisMohammadi GheisMohammadi self-assigned this Jul 11, 2023
@sophoah
Copy link
Contributor

sophoah commented Jul 11, 2023

was it tested locally ?

@ONECasey
Copy link
Contributor

was it tested locally ?

I ran it locally, and it worked on my end.

@ONECasey ONECasey merged commit dfb0c63 into dev Jul 11, 2023
3 checks passed
@ONECasey ONECasey deleted the fix/killnode branch July 11, 2023 14:50
@sophoah sophoah mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophoah sophoah sophoah approved these changes

@ONECasey ONECasey ONECasey approved these changes

@MaxMustermann2 MaxMustermann2 Awaiting requested review from MaxMustermann2

Assignees

@GheisMohammadi GheisMohammadi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GheisMohammadi @sophoah @ONECasey