Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reward] Abstract out block-reward, use rewarder, check result correct #1820

Merged
merged 4 commits into from
Nov 11, 2019
Merged

[reward] Abstract out block-reward, use rewarder, check result correct #1820

merged 4 commits into from
Nov 11, 2019

Conversation

fxfactorial
Copy link
Contributor

@fxfactorial fxfactorial commented Nov 11, 2019 •
edited
Loading

This is PR #3 of breaking this PR #1762 into smaller PRs, assumes PR#1, PR#2 merged into master, then will rebase this one to reflect that.

  1. Create package reward, has one interface, Distributor, reward.Distributor now a factored out block rewarder
  2. Use quorum type as the Awarder in engine/reward.go
  3. Double checks that the paid out amount is indeed total amount as block-reward

@fxfactorial fxfactorial requested a review from rlan35 November 11, 2019 01:40
@fxfactorial fxfactorial changed the title Use rewarder [reward] Abstract out block-reward, use rewarder, check result correct Nov 11, 2019
@fxfactorial fxfactorial merged commit a816320 into harmony-one:master Nov 11, 2019
@fxfactorial fxfactorial deleted the use-rewarder branch November 11, 2019 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlan35 rlan35 rlan35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxfactorial @rlan35