-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bcg: gateway: use Python's built-in json library #17
Conversation
This reduces the dependency list by one, since Python has a built-in JSON library with the same API. Signed-off-by: Alexandru Ardelean <[email protected]>
i've not tested this, but from a high-level perspective it looks correct; i just wanted to sort of ping / re-kick the discussion from #16 |
Hi, Line 109 in 603a826
But it's been a long time since we've done it, it's still been for python2.7 and it's stayed that way. |
I see that shouldn't be a problem anymore. |
oh, thank you for taking the patch i was hoping for a bit more discussion, since i don't want to break anything and i didn't test anything :) but if you're fine with this, then it's super for me; thank you :) |
I haven't done a release yet, I want to test the behavior, but it's true that with python3.x it was an unnecessary addiction. |
From: hardwario/bch-gateway#17 Signed-off-by: Alexandru Ardelean <[email protected]>
From: hardwario/bch-gateway#17 Signed-off-by: Alexandru Ardelean <[email protected]>
From: hardwario/bch-gateway#17 Signed-off-by: Alexandru Ardelean <[email protected]>
From: hardwario/bch-gateway#17 Signed-off-by: Alexandru Ardelean <[email protected]>
From: hardwario/bch-gateway#17 Signed-off-by: Alexandru Ardelean <[email protected]>
From: hardwario/bch-gateway#17 Signed-off-by: Alexandru Ardelean <[email protected]>
This reduces the dependency list by one, since Python has a built-in JSON
library with the same API.
Fixes #16
Signed-off-by: Alexandru Ardelean [email protected]