Improve variable initialization #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyrup
commented
Jun 8, 2023
jnyrup
commented
Jun 8, 2023
kblok
reviewed
Jun 8, 2023
| private readonly ConcurrentDictionary<string, string> _parentIds = new(); | ||
| private readonly ConcurrentDictionary<string, List<string>> _childIds = new(); | ||
| private readonly ConcurrentDictionary<string, List<TaskCompletionSource<Frame>>> _waitRequests = new(); | ||
| private readonly AsyncDictionaryHelper<string, Frame> _asyncFrames; | ||
|
|
||
| public FrameTree() | ||
| { | ||
| _frames = new(); | ||
| _asyncFrames = new AsyncDictionaryHelper<string, Frame>(_frames, "Frame {0} not found"); |
There was a problem hiding this comment.
I'd love C# to allow us to move this as well.
kblok
approved these changes
Jun 8, 2023
|
All actionable comments should be resolved now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has three parts each in separate commits:
1: combine initialization of fields with their declaration, this helps avoiding using a field before it has been initialized
2: Some small optimizations on dictionaries.
3: using target-typed new constructors some more places