More idiomatic usage of ConcurrentDictionary #2221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some places, where we can use built-in ConcurrentDictionary methods to reduce the number of lookups.
It might also improve thread-safety a tad, as currently a value could theoretically be removed/added between calls to
ContainsKey
andTryGetValue
.I refrained from updating
ChromeTargetManager.OnTargetCreated
andChromeTargetManager.OnAttachedToTarget
as thevalueFactory
might be evaluated more than once, to ensure that_targetFactoryFunc
is still only evaluated once.https://learn.microsoft.com/en-us/dotnet/api/system.collections.concurrent.concurrentdictionary-2.getoradd?view=net-7.0#system-collections-concurrent-concurrentdictionary-2-getoradd(-0-system-func((-0-1)))