Upgrade chrome to 1108766 (#2259)

* Upgrade chrome to 1115057 * Use 1108766 instead * Fix some tests * Prevent flaky test * Fix FrameGotoTests * Fix new assertion * unflake
hardkoded · Jul 26, 2023 · 7275e9a · 7275e9a
1 parent 42cfb93
commit 7275e9a
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 11 deletions.
diff --git a/lib/PuppeteerSharp.Tests/CoverageTests/CSSCoverageTests.cs b/lib/PuppeteerSharp.Tests/CoverageTests/CSSCoverageTests.cs
@@ -92,8 +92,8 @@ public async Task ShouldWorkWithMediaQueries()
             {
                 new CoverageEntryRange
                 {
-                    Start = 17,
-                    End = 38
+                    Start = 8,
+                    End = 40
                 }
             }, coverage[0].Ranges);
         }
@@ -111,8 +111,8 @@ public async Task ShouldWorkWithComplicatedUsecases()
                     ""End"": 297
                   },
                   {
-                    ""Start"": 327,
-                    ""End"": 433
+                    ""Start"": 306,
+                    ""End"": 435
                   }
                 ],
                 ""Text"": ""\n @charset \""utf - 8\"";\n@namespace svg url(http://www.w3.org/2000/svg);\n@font-face {\n  font-family: \""Example Font\"";\n src: url(\""./Dosis-Regular.ttf\"");\n}\n\n#fluffy {\n  border: 1px solid black;\n  z-index: 1;\n  /* -webkit-disabled-property: rgb(1, 2, 3) */\n  -lol-cats: \""dogs\"" /* non-existing property */\n}\n\n@media (min-width: 1px) {\n  span {\n    -webkit-border-radius: 10px;\n    font-family: \""Example Font\"";\n    animation: 1s identifier;\n  }\n}\n""

diff --git a/lib/PuppeteerSharp.Tests/CoverageTests/JSCoverageTests.cs b/lib/PuppeteerSharp.Tests/CoverageTests/JSCoverageTests.cs
@@ -48,6 +48,8 @@ public async Task ShouldReportSourceUrls()
         {
             await Page.Coverage.StartJSCoverageAsync();
             await Page.GoToAsync(TestConstants.ServerUrl + "/jscoverage/sourceurl.html");
+            // Prevent flaky tests.
+            await Task.Delay(1000);
             var coverage = await Page.Coverage.StopJSCoverageAsync();
             Assert.Single(coverage);
             Assert.Equal("nicename.js", coverage[0].Url);

diff --git a/lib/PuppeteerSharp.Tests/NavigationTests/FrameGoToTests.cs b/lib/PuppeteerSharp.Tests/NavigationTests/FrameGoToTests.cs
@@ -1,4 +1,3 @@
-using System.Collections.Generic;
 using System.Linq;
 using System.Net;
 using System.Threading.Tasks;
@@ -41,7 +40,17 @@ public async Task ShouldRejectWhenFrameDetaches()
             await waitForRequestTask;
             await Page.QuerySelectorAsync("iframe").EvaluateFunctionAsync("frame => frame.remove()");
             var exception = await Assert.ThrowsAsync<NavigationException>(async () => await navigationTask);
-            Assert.Equal("Navigating frame was detached", exception.Message);
+            Assert.Contains(
+                new[]
+                {
+                    exception.Message
+                },
+                message => new[]
+                {
+                    "Navigating frame was detached",
+                    "Error: NS_BINDING_ABORTED",
+                    "net::ERR_ABORTED"
+                }.Any(error => message.Contains(error)));
         }
 
         [PuppeteerTest("navigation.spec.ts", "Frame.goto", "should return matching responses")]

diff --git a/lib/PuppeteerSharp.Tests/PageTests/ExposeFunctionTests.cs b/lib/PuppeteerSharp.Tests/PageTests/ExposeFunctionTests.cs
@@ -138,6 +138,9 @@ public async Task ShouldKeepTheCallbackClean()
             await Page.ExposeFunctionAsync("compute", (int a, int b) => a * b);
             await Page.EvaluateFunctionAsync<int>("async () => await compute(9, 4)");
 
+            // Giving a tiny wait to let the connection clear the callback list.
+            await Task.Delay(300);
+
             // For CI/CD debugging purposes
             var session = (CDPSession)Page.Client;
             var message = "Expected an empty callback list. Found: \n";

diff --git a/lib/PuppeteerSharp/BrowserFetcher.cs b/lib/PuppeteerSharp/BrowserFetcher.cs
@@ -23,7 +23,7 @@ public class BrowserFetcher : IBrowserFetcher
         /// <summary>
         /// Default chromium revision.
         /// </summary>
-        public const string DefaultChromiumRevision = "1069273";
+        public const string DefaultChromiumRevision = "1108766";
 
         private const string PublishSingleFileLocalApplicationDataFolderName = "PuppeteerSharp";
 

diff --git a/lib/PuppeteerSharp/PuppeteerSharp.csproj b/lib/PuppeteerSharp/PuppeteerSharp.csproj
@@ -12,10 +12,10 @@
     <Description>Headless Browser .NET API</Description>
     <PackageId>PuppeteerSharp</PackageId>
     <PackageReleaseNotes></PackageReleaseNotes>
-    <PackageVersion>10.1.2</PackageVersion>
-    <ReleaseVersion>10.1.2</ReleaseVersion>
-    <AssemblyVersion>10.1.2.0</AssemblyVersion>
-    <FileVersion>10.1.2.0</FileVersion>
+    <PackageVersion>10.1.3</PackageVersion>
+    <ReleaseVersion>10.1.3</ReleaseVersion>
+    <AssemblyVersion>10.1.3.0</AssemblyVersion>
+    <FileVersion>10.1.3.0</FileVersion>
     <SynchReleaseVersion>false</SynchReleaseVersion>
     <StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
     <DebugType>embedded</DebugType>