Skip to content

Commit

Permalink
Do not display dependency warning if Salesforce Extension Pack (Expan…
Browse files Browse the repository at this point in the history
…ded) is installed

Fixes hardisgroupcom/sfdx-hardis#782
  • Loading branch information
nvuillam committed Sep 20, 2024
1 parent df25287 commit 5a75c42
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
- Default color is "no color", not green
- Fix: Do not update VsCode local config file with blank color if there wasn't a previous config value
- Fix: Refresh Status panel after upgrading plugins
- Fix: Do not display dependency warning if Salesforce Extension Pack (Expanded) is installed
- Remove sfdx-essentials plugin dependency
- NPM dependencies updates
- Upgrade all package dependencies
Expand Down
5 changes: 4 additions & 1 deletion src/hardis-plugins-provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,10 @@ export class HardisPluginsProvider
tooltip: `${extension.label} is installed`,
status: "dependency-ok",
};
const extInstance = vscode.extensions.getExtension(extension.id);
let extInstance = vscode.extensions.getExtension(extension.id);
if (!extInstance && extension.id === "salesforce.salesforcedx-vscode") {
extInstance = vscode.extensions.getExtension("salesforce.salesforcedx-vscode-expanded");
}
if (!extInstance) {
extensionItem.command = `code --install-extension ${extension.id}`;
extensionItem.tooltip = `Click to install VsCode Extension ${extension.label}`;
Expand Down

0 comments on commit 5a75c42

Please sign in to comment.