sfdx-hardis v5 #770
Merged
sfdx-hardis v5 #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Internalize packagexml append and removal with local commands, ISO from sfdx-essential ones
- sf hardis:packagexml:append
- sf hardis:packagexml:remove
nvuillam
force-pushed
the
migrate-sf-plugin
branch
from
ce05196 to
b0fa36b
Compare
Fixes #788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring explanations
The future deprecation of sfdx force:source:** commands on 6 november finally convinced us to switch everything from SFDX core to SF CLI core. (otherwise existing CI/CD pipelines would not work anymore from this date !)
Therefore, sfdx-hardis required a complete refactoring as described below, but this won't impact existing CI/CD and Monitoring pipelines.
We made many tests but risk zero do not exist, so if you see any bug, please report them ASAP and we'll solve them quickly :)
Major changes
Migrate plugin from SFDX plugin core to SF Cli Plugin core
Change background calls to legacy sfdx commands to call their SF Cli replacements
sfdx force:mdapi:convert->sf project convert mdapisfdx force:mdapi:deploy->sf project deploy start --metadata-dirsfdx force:source:retrieve->sf project retrieve startsfdx force:source:deploy->sf project deploy startsfdx force:source:pull->sf project retrieve startsfdx force:source:push->sf project deploy startsfdx force:source:tracking:clear->sf project delete trackingsfdx force:source:manifest:create->sf project generate manifestsfdx sgd:source:delta->sf sgd:source:deltasfdx force:org:create->sf org create sandbox|sf org create scratchsfdx force:org:list->sf org listsfdx force:org:delete->sf org delete scratchsfdx config:get->sf config getsfdx config:set->sf config setsfdx auth:web:login->sf org login websfdx auth:jwt:grant->sf org login jwtsfdx auth:sfdxurl:store->sf org login sfdx-urlsfdx org:login:device->sf org login devicesfdx force:data:record:get->sf data get recordsfdx force:data:record:update->sf data update recordsfdx force:data:soql:query->sf data querysfdx force:data:bulk:delete->sf data delete bulksfdx alias:list->sf alias listsfdx alias:set->sf alias setsfdx force:apex:test:run->sf apex run testsfdx force:apex:execute->sf apex runsfdx force:package:create->sf package createsfdx force:package:version:create->sf package version createsfdx force:package:version:delete->sf package version deletesfdx force:package:version:list->sf package version listsfdx force:package:version:promote->sf package version promotesfdx force:package:installed:list->sf package installedsfdx force:package:install->sf package installsfdx force:user:password:generate->sf org generate passwordsfdx force:user:permset:assign->sf org assign permsetsfdx hardis:_->sf hardis:_New wrappers commands for SF Cli deployment commands
sf hardis project deploy validate-> Wrapssf project deploy validatesf hardis project deploy quick-> Wrapssf project deploy quicksf hardis project deploy start-> Wrapssf project deploy startNew Features / Enhancements
true, the command will be run only one time per org. A record of SfdxHardisTrace__c is stored to make that possible (it needs to be existing in target org)availableTargetBranches, using a comma. For examples,- integration,Choose this branch if you are on the BUILD side of the project !Change Matching RuleFixes
Documentation
Deprecations
Deprecate wrapper commands matching sfdx commands that will be removed. All replaced by sf hardis deploy start (TODO: complete !)
sfdx hardis:source:pushsfdx hardis:source:deploysfdx hardis:mdapi:retrievesfdx hardis:mdapi:deployDeprecate
hardis:deploy:sources:metadataas nobody uses metadata format anymoreRemovals
Replace puppeteer by puppeteer-core: it means that if you use a command requiring puppeteer, please make sure to have a Chrome available in your environment (already integrated within the Docker image)
Get rid of sfdx-essentials plugin dependency by internalizing its used commands
sf hardis:packagexml:appendsf hardis:packagexml:removesf hardis:project:clean:filter-xml-contentRemove npm dependencies (some of them not maintained anymore)
Remove not used keyValueStores to keep only Salesforce one
Fixed GitHub issues: