JIRA labels for DEPLOY_BEFORE_MERGE = true

[0ptaq0]

Some time ago a great feature was introduced to support my exotic way of deployment: SFDX_HARDIS_DEPLOY_BEFORE_MERGE: "true"
Thank you for that!

When we have a pull/merge request, the merge results (diff) are deployed to the target branch, and if that succeeded the pull/merge request is merged.

I am using that approach but have one ask for additional support for my "deploy before merge" for jira labels.
If SFDX_HARDIS_DEPLOY_BEFORE_MERGE: "true" create a tag in a way:
UPPERCASE(target_branch_name) + "_DEPLOYED"

Currently, we do have: UPPERCASE(branch_name) + "_DEPLOYED" which is pointing to the source branch od the merge request and is not really accurate in that case.

[nvuillam]

@0ptaq0 that should be hard to implement :)

Time for your first PR to sfdx-hardis ? 😇

The code building the tag is here ->

sfdx-hardis/src/common/ticketProvider/ticketProviderRoot.ts

Line 27 in 24b2275

let tag = currentGitBranch.toUpperCase() + "_DEPLOYED";

You can add a condition using isDeployBefore merge

To get the targetBranch, you can use

const prInfo = await GitProvider.getPullRequestInfo();
const targetBranch = prInfo?.targetBranch || process.env.FORCE_TARGET_BRANCH

[0ptaq0]

Hi @nvuillam,

This is my first TS code so I have no idea what I am doing, but I managed to make some changes locally on a feature branch.
I tried to push it but I am getting 403:

git push origin features/deploy-before-merge-label
info: please complete authentication in your browser...
remote: Permission to hardisgroupcom/sfdx-hardis.git denied to 0ptaq0.
fatal: unable to access 'https://github.com/hardisgroupcom/sfdx-hardis.git/': The requested URL returned error: 403

Can you please give me permission to push?
Or share some other way to have my changes implemented :D

[0ptaq0]

Hi @nvuillam, just a reminder, how should I add the PR?

[nvuillam]

@0ptaq0 sorry for the delay :)

You need to fork the repo

, then create a PR from your forked repo branch to this repo main branch :)

Fork: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo

PR from fork: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

[0ptaq0]

@nvuillam thanks!
I feel like a newbie now, haha but it's my first contribution to someone else public repo.

Here is the PR - #960

[nvuillam]

@0ptaq0 and not the last I hope ! :)

Going to check your PR :)