Skip to content

Commit

Permalink
fix(core): don't include a v8 dependency as this breaks docs.rs (deno…
Browse files Browse the repository at this point in the history
  • Loading branch information
mmastrac authored Jul 31, 2023
1 parent 2f9f8c9 commit d526874
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ops/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ strum_macros.workspace = true
syn.workspace = true
syn2.workspace = true
thiserror.workspace = true
v8.workspace = true

[dev-dependencies]
pretty_assertions.workspace = true
Expand Down
6 changes: 1 addition & 5 deletions ops/op2/dispatch_slow.rs
Original file line number Diff line number Diff line change
Expand Up @@ -734,11 +734,7 @@ fn throw_type_error(
message: String,
) -> Result<TokenStream, V8MappingError> {
// Sanity check ASCII and a valid/reasonable message size
debug_assert!(
message.is_ascii()
&& message.len() < v8::String::max_length()
&& message.len() < 1024
);
debug_assert!(message.is_ascii() && message.len() < 1024);

let maybe_scope = if generator_state.needs_scope {
quote!()
Expand Down

0 comments on commit d526874

Please sign in to comment.