Triplelift Adaptor: Use Floors Module (prebid#5329)

* access floor from floors module * int -> float and null check * let -> const
happypancake · Jun 22, 2020 · 8a13aa6 · 8a13aa6
1 parent e918caa
commit 8a13aa6
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/modules/tripleliftBidAdapter.js b/modules/tripleliftBidAdapter.js
@@ -111,7 +111,7 @@ function _buildPostBody(bidRequests) {
     return {
       id: index,
       tagid: bid.params.inventoryCode,
-      floor: bid.params.floor,
+      floor: _getFloor(bid),
       banner: {
         format: _sizes(bid.sizes)
       }
@@ -138,6 +138,22 @@ function _buildPostBody(bidRequests) {
   return data;
 }
 
+function _getFloor (bid) {
+  let floor = null;
+  if (typeof bid.getFloor === 'function') {
+    const floorInfo = bid.getFloor({
+      currency: 'USD',
+      mediaType: 'banner',
+      size: _sizes(bid.sizes)
+    });
+    if (typeof floorInfo === 'object' &&
+    floorInfo.currency === 'USD' && !isNaN(parseFloat(floorInfo.floor))) {
+      floor = parseFloat(floorInfo.floor);
+    }
+  }
+  return floor !== null ? floor : bid.params.floor;
+}
+
 function getUnifiedIdEids(bidRequests) {
   return getEids(bidRequests, 'tdid', 'adserver.org', 'TDID');
 }

diff --git a/test/spec/modules/tripleliftBidAdapter_spec.js b/test/spec/modules/tripleliftBidAdapter_spec.js
@@ -299,6 +299,15 @@ describe('triplelift adapter', function () {
       const { data: payload } = request;
       expect(payload.ext).to.deep.equal(undefined);
     });
+    it('should get floor from floors module if available', function() {
+      const floorInfo = {
+        currency: 'USD',
+        floor: 1.99
+      };
+      bidRequests[0].getFloor = () => floorInfo;
+      const request = tripleliftAdapterSpec.buildRequests(bidRequests, bidderRequest);
+      expect(request.data.imp[0].floor).to.equal(1.99);
+    });
   });
 
   describe('interpretResponse', function () {