Skip to content

Commit

Permalink
Fix creativeId field in Yieldmo bid response (prebid#3053)
Browse files Browse the repository at this point in the history
* Fix creativeId field in bid response 

We had an issue whereby prebid wasn't passing us yieldmo bids even though we could see them in the network requests. Turned out that the `creativeId` field was being set to `undefined` because the response body from the yieldmo server uses snake case, not camel case. Tested the proposed fix and saw prebid log the bid as expected.

* Fix test
  • Loading branch information
beth92 authored and ptomasroos committed Sep 25, 2018
1 parent 8b6af95 commit 72f66b3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion modules/yieldmoBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function createNewBid(response) {
cpm: response.cpm,
width: response.width,
height: response.height,
creativeId: response.creativeId,
creativeId: response.creative_id,
currency: CURRENCY,
netRevenue: NET_REVENUE,
ttl: TIME_TO_LIVE,
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/yieldmoBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ describe('YieldmoAdapter', function () {
width: 300,
height: 250,
ad: '<html><head></head><body><script>//GEX ad object</script><div id=\"ym_123\" class=\"ym\"></div><script>//js code</script></body></html>',
creativeId: '9874652394875'
creative_id: '9874652394875'
}],
header: 'header?'
};
Expand Down

0 comments on commit 72f66b3

Please sign in to comment.