Fix Web Workers compatibility #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest Webpack generated dist files no longder reference "window". Thus those generated files are compatible with Web Workers.
|
@Marsup Can you review? |
Marsup
reviewed
Jun 29, 2021
browser/webpack.mocha.js
Outdated
Comment on lines
21
to
23
| WebpackConfig.plugins.push(new Webpack.ProvidePlugin({ | ||
| process: 'process/browser', | ||
| })); |
There was a problem hiding this comment.
Looks like we can remove process by doing this.
Suggested change
| WebpackConfig.plugins.push(new Webpack.ProvidePlugin({ | |
| process: 'process/browser', | |
| })); | |
| WebpackConfig.plugins.push(new Webpack.DefinePlugin({ | |
| 'process.env.NODE_DEBUG': false, | |
| })); |
@Marsup That doesn't seem to be related to the web compatibility issue that fixed in this PR. I have no idea about the context of that code piece. It will be helpful if you can take that part of the work. |
|
@Marsup Leaving this for you to merge. |
|
I'm merging this as is and will bring some modifications afterwards. @hueniverse I'll leave the version numbering to you, I'm not sure which applies in this case. |
|
@Marsup I assume this is not a breaking change? |
|
Unlikely, minor at best. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest Webpack generated dist files no longer reference "window". Thus those
generated files are compatible with Web Workers.
Fixes #2251