-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classify joi as NodeJS only tool? #944
Comments
Use joi-browser. |
@Marsup Sorry, but why this isn't mentioned in docs here? I am sure you getting bunch of issues like this. Single message in readme would really help, don't you think? |
Because that's just one way to do it, you might have a different build process, I don't want to assume anything about how you package your app. |
How is that assumption of anything? Clearly It's your fight in the end, but I am surely not a last person who gets confused about this. |
@Marsup I think he's just suggesting a short blurb in the README, such as:
|
Oh I know what he meant, and there's no single way to do that, you'll have to figure it out based on your own stack at some point. |
@Marsup I don't follow. What's wrong about using |
First, I can do without the snarky comments, thanks. Second, I ship browser code, I ship it with ES2015 code because I can, this is my target, I still need a build step to deal with hoek, but I don't need nor desire the fallback to ES5, thus I don't need joi-browser. There's almost nothing wrong with it, it's just for legacy browsers and more fat than it needs to be. Added some text anyway... |
Thank you for the commit, much appreciated not just by me but surely also by future consumers. I apparently need |
I find it very misleading to not classify that Joi is for NodeJS only. I've implemented bunch of validation with Joi but only to realize that I cannot use it because IE11 is missing some ES6 features in
hoek
module.Can you please refer me to some other similar library that is supported in browser as well?
Frankly I find it bit overkill to use whole
hoek
here just for a couple of utility methods that can be obtained elsewhere. By removing this dependency there are suddenly no issues with usingjoi
in browser and that would be real joy.The text was updated successfully, but these errors were encountered: