Fix cloning Util.inherit() subclassed errors #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marsup
pushed a commit
that referenced
this pull request
Nov 14, 2024
Marsup
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue in #400.
Util.inherits()(essentiallyObject.setPrototypeOf()on prototype properties) subclassed errors somehow trigger differentstructuredClone()cloning logic than regular ES6 subclassed errors. This seems to be a fallout of the issue in nodejs/node#4179, which found that the prototype chain is not applied.The fix is to detect these (using a failing
Error.isPrototypeOf(proto.constructor)), and fallback to the old cloning logic. Incidentally, it seems that custom errors subclassed usingUtil.inherits()continue to preserve the stack using the old logic.