Make pre-routed request.route property null #4433
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the value of
request.route
duringonRequest
processing to closer match the docs. As it is, it just returns thenotFound
route. I updated the docs to clarify that the value will benull
.The PR ended up being quite extensive, since the internal logic uses the
route
property when it has not been routed. I fixed this by using the internal_route
instead.This PR also contains a fix for a minor issue with
response.escape(true)
, which would be ignored.