Add support for custom messages on request completion/receive/failure #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hapi-pino 9.2.0 and 9.3.0 added a few changes to the default output of "request completed" and "request error", that while useful for certain transports it can be redundant for others (the same information is already included). This pull request adds a way to customize these messages without changing the defaults:
customRequestStartMessage- to customize messages when enabled bylogRequestStartcustomRequestCompleteMessage- to customize messages when enabled bylogRequestCompletecustomRequestErrorMessage- to customize request error messagesThese properties are based on equivalent properties existing in other implementations, specifically in
pino-http, but the terminology is changed to fit better with existing terminology in this project.This also addresses #162 without unnecessarily changing the existing defaults.