Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document 1st arg can be an Error #297

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Document 1st arg can be an Error #297

merged 1 commit into from
Feb 11, 2023

Conversation

michelbl
Copy link
Contributor

Fixes #290

Only Typescript types, comments and variable name are modified.

@michelbl michelbl changed the title [https://github.com/hapijs/boom/issues/290] Document 1st arg can be an Error Document 1st arg can be an Error Jun 10, 2022
Marsup
Marsup reviewed Sep 13, 2022
View reviewed changes
Copy link
Contributor

@Marsup Marsup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's just missing readme and typings tests and it can be shipped. Are you up for it or should it be handled in another PR?

Nargonath
Nargonath approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@Nargonath Nargonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update the PR for tests and docs or do it separately, both are fine for me.

@Nargonath Nargonath added bug Bug or defect types TypeScript type definitions labels Sep 14, 2022
@Marsup Marsup added this to the 10.0.1 milestone Feb 11, 2023
@Marsup Marsup merged commit aa83351 into hapijs:master Feb 11, 2023
@alanplatt alanplatt mentioned this pull request Sep 19, 2024
Closed
@ffcplatform ffcplatform mentioned this pull request Sep 19, 2024
Closed
@doperiddle doperiddle mentioned this pull request Nov 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marsup Marsup Marsup left review comments

@Nargonath Nargonath Nargonath approved these changes

Assignees
No one assigned
Labels
bug Bug or defect types TypeScript type definitions
Projects
None yet
Milestone
10.0.1
Development

Successfully merging this pull request may close these issues.

Missing Boom.notFound etc error argument type support
3 participants
@michelbl @Nargonath @Marsup