-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add composite interceptor registry #6511
Open
jamesagnew
wants to merge
14
commits into
master
Choose a base branch
from
ja_20241125_composite_interceptor_improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add composite interceptor registry #6511
jamesagnew
wants to merge
14
commits into
master
from
ja_20241125_composite_interceptor_improvements
+1,034
−707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesagnew
requested review from
michaelabuckley,
tadgh and
fil512
as code owners
November 25, 2024 20:54
Formatting check succeeded! |
tadgh
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending questions/comments
hapi-fhir-base/src/main/java/ca/uhn/fhir/interceptor/api/Pointcut.java
Outdated
Show resolved
Hide resolved
hapi-fhir-base/src/main/java/ca/uhn/fhir/interceptor/executor/BaseInterceptorService.java
Show resolved
Hide resolved
...esources/ca/uhn/hapi/fhir/changelog/7_8_0/6511-rework-composite-interceptor-broadcaster.yaml
Outdated
Show resolved
Hide resolved
...-fhir-server/src/main/java/ca/uhn/fhir/rest/server/util/CompositeInterceptorBroadcaster.java
Show resolved
Hide resolved
…_8_0/6511-rework-composite-interceptor-broadcaster.yaml Co-authored-by: Tadgh <[email protected]>
…ub.com:hapifhir/hapi-fhir into ja_20241125_composite_interceptor_improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interceptors can be defines against the registry on the RestfulServer, or on the registry in the JPA repository. Because these are separate registries, the
order()
attribute on theHook
annotation isn't correctly processed today across the two registries. This PR fixes that.