Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency in search deleting #1759

Merged
merged 3 commits into from
Mar 17, 2020

Conversation

jamesagnew
Copy link
Collaborator

No description provided.

@jamesagnew jamesagnew requested a review from fil512 March 13, 2020 21:04
Copy link
Collaborator

@fil512 fil512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I didn't entirely understand the logic in the test, but I think that's okay.

@@ -56,17 +56,18 @@
public static final int DEFAULT_MAX_RESULTS_TO_DELETE_IN_ONE_STMT = 500;
public static final int DEFAULT_MAX_RESULTS_TO_DELETE_IN_ONE_PAS = 20000;
public static final long SEARCH_CLEANUP_JOB_INTERVAL_MILLIS = 10 * DateUtils.MILLIS_PER_SECOND;
public static final int DEFAULT_MAX_DELETE_CANDIDATES_TO_FIND = 2000;
private static final Logger ourLog = LoggerFactory.getLogger(DatabaseSearchCacheSvcImpl.class);
private static int ourMaximumResultsToDeleteInOneStatement = DEFAULT_MAX_RESULTS_TO_DELETE_IN_ONE_STMT;
private static int ourMaximumResultsToDeleteInOnePass = DEFAULT_MAX_RESULTS_TO_DELETE_IN_ONE_PAS;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo. ONE_PAS

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #1759 into master will increase coverage by <.01%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1759      +/-   ##
===========================================
+ Coverage      80.4%   80.4%   +<.01%     
- Complexity    13595   13600       +5     
===========================================
  Files           943     943              
  Lines         51078   51086       +8     
  Branches       8322    8324       +2     
===========================================
+ Hits          41068   41075       +7     
  Misses         6822    6822              
- Partials       3188    3189       +1
Impacted Files Coverage Δ Complexity Δ
...r/jpa/search/cache/DatabaseSearchCacheSvcImpl.java 95.91% <84.61%> (-0.72%) 35 <3> (+3)
.../java/ca/uhn/fhir/jpa/dao/predicate/QueryRoot.java 96.42% <0%> (-3.58%) 17% <0%> (-1%)
...a/ca/uhn/fhir/jpa/bulk/BulkExportResponseJson.java 69.23% <0%> (ø) 6% <0%> (ø) ⬇️
...ion/module/subscriber/ResourceDeliveryMessage.java 57.14% <0%> (ø) 12% <0%> (ø) ⬇️
...n/java/ca/uhn/fhir/jpa/binstore/StoredDetails.java 100% <0%> (ø) 13% <0%> (ø) ⬇️
...module/subscriber/ResourceDeliveryJsonMessage.java 72.72% <0%> (ø) 4% <0%> (ø) ⬇️
...a/subscription/module/ResourceModifiedMessage.java 89.47% <0%> (ø) 23% <0%> (ø) ⬇️
...ription/module/subscriber/BaseResourceMessage.java 81.25% <0%> (ø) 6% <0%> (ø) ⬇️
...jpa/subscription/module/CanonicalSubscription.java 84.45% <0%> (ø) 37% <0%> (ø) ⬇️
...module/subscriber/ResourceModifiedJsonMessage.java 63.63% <0%> (ø) 3% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b9d9a...26f4e09. Read the comment docs.

@jamesagnew jamesagnew merged commit 288abe4 into master Mar 17, 2020
@jamesagnew jamesagnew deleted the ja_20200313_efficiency_in_search_deleting branch March 17, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants