-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve efficiency in search deleting #1759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. I didn't entirely understand the logic in the test, but I think that's okay.
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/data/ISearchDao.java
Outdated
Show resolved
Hide resolved
...ir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/cache/DatabaseSearchCacheSvcImpl.java
Show resolved
Hide resolved
@@ -56,17 +56,18 @@ | |||
public static final int DEFAULT_MAX_RESULTS_TO_DELETE_IN_ONE_STMT = 500; | |||
public static final int DEFAULT_MAX_RESULTS_TO_DELETE_IN_ONE_PAS = 20000; | |||
public static final long SEARCH_CLEANUP_JOB_INTERVAL_MILLIS = 10 * DateUtils.MILLIS_PER_SECOND; | |||
public static final int DEFAULT_MAX_DELETE_CANDIDATES_TO_FIND = 2000; | |||
private static final Logger ourLog = LoggerFactory.getLogger(DatabaseSearchCacheSvcImpl.class); | |||
private static int ourMaximumResultsToDeleteInOneStatement = DEFAULT_MAX_RESULTS_TO_DELETE_IN_ONE_STMT; | |||
private static int ourMaximumResultsToDeleteInOnePass = DEFAULT_MAX_RESULTS_TO_DELETE_IN_ONE_PAS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo. ONE_PAS
hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/SearchCoordinatorSvcImplTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1759 +/- ##
===========================================
+ Coverage 80.4% 80.4% +<.01%
- Complexity 13595 13600 +5
===========================================
Files 943 943
Lines 51078 51086 +8
Branches 8322 8324 +2
===========================================
+ Hits 41068 41075 +7
Misses 6822 6822
- Partials 3188 3189 +1
Continue to review full report at Codecov.
|
No description provided.