Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the TargetSecuritySystemState enum #44

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Update the TargetSecuritySystemState enum #44

merged 1 commit into from
Apr 16, 2018

Conversation

j-mutter
Copy link
Contributor

@j-mutter j-mutter commented Apr 15, 2018 •
edited
Loading

As per the Homekit documentation the name of the constant for disarming the security system is disarm not disarmed, as this is the TargetSecuritySystemState, not the CurrentSecuritySystemState.

I also updated the descriptions to be more in line with the intent of the TargetSecuritySystemState enum

andylintner
andylintner approved these changes Apr 16, 2018
View reviewed changes
Copy link
Collaborator

@andylintner andylintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@andylintner andylintner merged commit 6985b30 into hap-java:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andylintner andylintner andylintner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-mutter @andylintner