Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adding support for Mixtral and Gemma models #1247

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

martinakaduc
Copy link

This pull request intends to add support for Mixtral and Gemma as LLM backbone.

@muhark
Copy link

muhark commented Mar 11, 2024

@martinakaduc I see some of my comments in here--did you figure out the necessary changes to the preprocess_gemma function? :)
FWIW yours looks right, I realize that I may have been running an old version of the chat template that didn't include the BOS token when I was developing.

@martinakaduc
Copy link
Author

martinakaduc commented Mar 11, 2024

preprocess_gemma

@muhark Yes, I have referenced your code. I also figured out the problem with preprocess_gemma where <end_of_turn>\n requires 2 tokens.

I have successfully trained my llava_gemma for Vietnamese! 😄 (https://huggingface.co/ura-hcmut/GemSUraV-7B)

@ShawnAn-WHU
Copy link

@martinakaduc Sorry to bother. I see some warnings when pretrain Mixtral 8*7B, just like #1417. Did you face the same problem? Thanks in advance!

@Jayantverma2
Copy link

why did you use
"additional_special_tokens": [
"<start_of_turn>",
"<end_of_turn>"
],
instead of
"bos_token": "",
"eos_token": "",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants