test: add a failing test for vuejs#10852

haoqunjiang · May 9, 2024 · d73dab7 · d73dab7
1 parent fdd1dd5
commit d73dab7
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 27 deletions.
diff --git a/packages/compiler-sfc/__tests__/compileTemplate.spec.ts b/packages/compiler-sfc/__tests__/compileTemplate.spec.ts
@@ -1,4 +1,5 @@
 import { type RawSourceMap, SourceMapConsumer } from 'source-map-js'
+import { parse as babelParse } from '@babel/parser'
 import {
   type SFCTemplateCompileOptions,
   compileTemplate,
@@ -452,6 +453,36 @@ test('prefixing edge case for reused AST ssr mode', () => {
   ).not.toThrowError()
 })
 
+// #10852
+test('non-identifier expression in legacy filter syntax', () => {
+  const src = `
+  <template>
+    <div>
+      Today is
+      {{ new Date() | formatDate }}
+    </div>
+  </template>
+  `
+
+  const { descriptor } = parse(src)
+  const compilationResult = compileTemplate({
+    id: 'xxx',
+    filename: 'test.vue',
+    ast: descriptor.template!.ast,
+    source: descriptor.template!.content,
+    ssr: false,
+    compilerOptions: {
+      compatConfig: {
+        MODE: 2,
+      },
+    },
+  })
+
+  expect(() => {
+    babelParse(compilationResult.code, { sourceType: 'module' })
+  }).not.toThrow()
+})
+
 interface Pos {
   line: number
   column: number

diff --git a/packages/vue-compat/__tests__/filters.spec.ts b/packages/vue-compat/__tests__/filters.spec.ts
@@ -252,15 +252,4 @@ describe('FILTERS', () => {
     }).$mount()
     expect(vm.$el.textContent).toBe('6000000010000000')
   })
-
-  it('#10852', () => {
-    const vm = new Vue({
-      template: `<div>{{ new Date() | formatDate }}</div>`,
-      filters: {
-        formatDate: (value: any) => new Date(value).toISOString().slice(0, 10),
-      },
-    }).$mount()
-    expect(vm.$el.textContent).toBe('2024-05-07')
-    expect(CompilerDeprecationTypes.COMPILER_FILTERS).toHaveBeenWarned()
-  })
 })
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -1,3 +1,2 @@
 packages:
   - 'packages/*'
-  - 'explorations/*'