-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated everything for Python3.6+ and TensorFlow1.13+ #59
base: master
Are you sure you want to change the base?
Conversation
Thank you for your work, but trying to run your code I faced a problem. Trying to restore a model from the checkpoint provided in orginal repo, I got an error:
Is it possible at all to use this saved checkpoint with your updated implementation or it's my fault somewhere? |
Because I upgraded the code and factored out certain parts, you cannot use the previously pretrained model by hanzhanggit. So there are two options at the moment:
Sorry to be a downer |
That was my first thought, but I was unsure so decided to clarify. |
Could you please provide information on the amount of video memory required for the model training? |
Good news! Uploaded the pretrained model on my StackGAN forked repo as well as the updated birds_skipthoughts_demo.py file for python3 usage. It took me 3 days to train the model on a NVIDIA GPU 1080 Ti Founder's edition (with 11 Gbs). Also the file size was ~1Gbs large for the all the pictures of the birds |
I can't comment some lines right in the PR, as they were created by original authors and left unedited by you. That's why I'll leave some comments here File misc/skipthoughts.py lines 80-81 should be like: utable = numpy.load(path_to_tables + 'utable.npy', encoding='latin1', allow_pickle=True)
btable = numpy.load(path_to_tables + 'btable.npy', encoding='latin1', allow_pickle=True) These are files from original skipthoughts source, which wasn't updated to Python3. that's why What's more, I anyway get an error loading your checkpoint. It says:
I tried to figure out, what's wrong, but failed. What could have caused it? I used your code as is without editing the model or anything, but changes listed above Thank you for your code and support |
hello, how can test ? |
@YiXun31: If by test you mean run own our text captions, inside the |
Co-Authored-By: kramarov-evg <[email protected]>
@kramarov-evg : I'll be completely honest, I did not train the model using skip-thoughts because I did not want to download Theano and/ or upgrade that code for training. However, after looking into the problem, I found a way around Theano. There is a TensorFlow implementation by Chris Shallue. At the moment, I am rewriting my |
hello |
@akhilvasvani, not sure it'll succeed, as wsl doesn't yet support CUDA integration. @YiXun31, please, let me know if it works |
Display after execution |
Search for instructions on installing torch. Can be found in README by the Torch link. That's for |
Do you have to execute the .sh file? |
@YiXun31: You can execute the birds_demo.py python file. You will just have to provide the arguments yourself. If you look at the .sh file you can specifically what arguments you have to fulfill. @kramarov-evg: what is wsl? |
@akhilvasvani WSL stands for Windows Subsystem for Linux. If I'm not mistaken it was in the link, you provided as a solution Moreover won't he need to generate embeddings for sentences in example_samples.txt? If so, they're generated using Torch, which has no Windows support, but compiling from source, which happens to be really complicated task. Correct me if I'm wrong That was the only reason I wanted to use skip-thoughts. This has full Windows compatibility |
@akhilvasvani Hello I can't find the birds_demo.py . |
@YiXun31 You should wait until author fully implements skip-thought embeddings. Just like I do. Maybe there's a different way that I'm not informed about, IDK |
@kramarov-evg Thank you for your answer. |
@kramarov-evg: |
@akhilvasvani Wow, congratulations. Amazing news. Waiting for your next pretrained model. No words can describe my gratefulness for this support and contribution |
@akhilvasvani How's it going? |
@akhilvasvani |
I'm so sorry @kramarov-evg. I had to stop training on the skip-thoughts model for a short while I worked on another project. Sure, I can do that. Let me get on that. Also nice find with that script. For future developers though, I will keep training the skip-thoughts model |
@akhilvasvani no problem with that at all. Finally that's not your obligation :-) Hope you finish it once |
@kramarov-evg: I finally got the skip-thoughts model to work! I got the pickle file from the pretrained skip-thoughts model (for training and testing) and now I am training the StackGAN model with it. Stay tuned for an update |
@akhilvasvani I tried executing the skip-thoughts.py. Now I'm stuck at this check point error mwentioned by @kramarov-evg earlier. I don't know where to take it from here without pretrained model.
Thanks in advance |
Thx in advance. |
Hi @ChelyYi + @vigneshdurairaj, the reason why the script does not run is because I have to post the generated the pickle file for skip-thoughts text-embeddings. At the moment, I am retraining the StackGAN model so you can use it with the skip-thoughts embeddings |
@akhilvasvani Thx, waiting for your new model. |
@akhilvasvani Thanks a lot for the updated code for python 3.6+ and Tensorflow 1.13+. I was struggling to run the old code : ) |
hey @akhilvasvani I followed your setup in the fork available on your GH account. However, I get the following error. let me know if you've seen it or anything similar.
Tried debugging, things are fine till the following line https://github.com/akhilvasvani/StackGAN-v2/blob/94df11d10dba2ddc62aa4c339617d846195d6a17/code/main.py#L141 Tried reducing batch size etc, but to no avail |
Hi @shikhar-scs, apologies for the wait. I did not get this error. What GPU are you using? And what is your memory size? |
@gowthamvbhat I can provide an updated model by later this weekend |
I tried a TITAN V and also a GeForce GTX 1080. Same error on both. It works on my local with gpu=-1, some issue with the data folder maybe.
Wanted to train it actually for different scenarios. |
Oh, that's weird. You should enough memory on those GPUs. For memory: it's 11 GB or more? Wait, what type of local GPU do you have? Are you using these GPUs on the cloud? I trained the model locally |
@akhilvasvani That would be great! Thank you. |
Slightly more than that on each. I have a VM, for local I was trying on my MacBook Pro. The code was running at the least. I did an scp of the exact same zip file of the directory to my VM and it stopped working with the same code. Anyways I guess something is off from my side. Let me figure it out. Thanks for your response. |
Hi Sir can You provide a solution |
|
Updated all the code for Python3.6+ and TensorFlow1.13+ usage