This repository has been archived by the owner on Apr 22, 2019. It is now read-only.
handle korean keyboard properly #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to this PR |
kamkuul
pushed a commit
to nic004/GrowingTextView
that referenced
this pull request
Jul 1, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we use korean keyboard, UITextView occasionally fires 2 textViewDidChange events simultaneously.
for example, there is "버그버그ㅂ". we presse the "ㅓ" key. then text is changed to "버그버그버"
but UITextView fires 2 textViewDidChange events. The first event is "버그버그ㅂ" to "버그버그". The second event is "버그버그" to "버그버그버".
so we should use the last event of these events.
current version capture
https://www.dropbox.com/s/j7jswke288ye6o5/GrowingTextView-Korean-Bug.mov
fixed version capture
https://www.dropbox.com/s/2ehazrxkgbotq1h/GrowingTextView-Korean-Bug-Fixed.mov