review comments #933
Security advisories found
2 advisories, 2 unmaintained
Details
Vulnerabilities
RUSTSEC-2024-0019
Tokens for named pipes may be delivered after deregistration
Details | |
---|---|
Package | mio |
Version | 0.7.14 |
URL | GHSA-r8w9-5wcg-vfj7 |
Date | 2024-03-04 |
Patched versions | >=0.8.11 |
Unaffected versions | <0.7.2 |
Impact
When using named pipes on Windows, mio will under some circumstances return invalid tokens that correspond to named pipes that have already been deregistered from the mio registry. The impact of this vulnerability depends on how mio is used. For some applications, invalid tokens may be ignored or cause a warning or a crash. On the other hand, for applications that store pointers in the tokens, this vulnerability may result in a use-after-free.
For users of Tokio, this vulnerability is serious and can result in a use-after-free in Tokio.
The vulnerability is Windows-specific, and can only happen if you are using named pipes. Other IO resources are not affected.
Affected versions
This vulnerability has been fixed in mio v0.8.11.
All versions of mio between v0.7.2 and v0.8.10 are vulnerable.
Tokio is vulnerable when you are using a vulnerable version of mio AND you are using at least Tokio v1.30.0. Versions of Tokio prior to v1.30.0 will ignore invalid tokens, so they are not vulnerable.
Workarounds
Vulnerable libraries that use mio can work around this issue by detecting and ignoring invalid tokens.
Technical details
When an IO resource registered with mio has a readiness event, mio delivers that readiness event to the user using a user-specified token. Mio guarantees that when an IO resource is deregistered, then it will never return the token for that IO resource again. However, for named pipes on windows, mio may sometimes deliver the token for a named pipe even though the named pipe has been previously deregistered.
This vulnerability was originally reported in the Tokio issue tracker: tokio-rs/tokio#6369
This vulnerability was fixed in: tokio-rs/mio#1760
Thank you to @rofoun and @radekvit for discovering and reporting this issue.
RUSTSEC-2024-0336
rustls::ConnectionCommon::complete_io
could fall into an infinite loop based on network input
Details | |
---|---|
Package | rustls |
Version | 0.20.9 |
URL | GHSA-6g7w-8wpp-frhj |
Date | 2024-04-19 |
Patched versions | >=0.23.5,>=0.22.4, <0.23.0,>=0.21.11, <0.22.0 |
If a close_notify
alert is received during a handshake, complete_io
does not terminate.
Callers which do not call complete_io
are not affected.
rustls-tokio
and rustls-ffi
do not call complete_io
and are not affected.
rustls::Stream
and rustls::StreamOwned
types use
complete_io
and are affected.
Warnings
RUSTSEC-2023-0049
tui
is unmaintained; useratatui
instead
Details | |
---|---|
Status | unmaintained |
Package | tui |
Version | 0.16.0 |
URL | fdehau/tui-rs#654 |
Date | 2023-08-07 |
The tui
crate is no longer maintained.
Consider using the ratatui
crate instead.
RUSTSEC-2024-0320
yaml-rust is unmaintained.
Details | |
---|---|
Status | unmaintained |
Package | yaml-rust |
Version | 0.4.5 |
URL | rustsec/advisory-db#1921 |
Date | 2024-03-20 |
The maintainer seems unreachable.
Many issues and pull requests have been submitted over the years
without any response.
Alternatives
Consider switching to the actively maintained yaml-rust2
fork of the original project: