Add crates/ and tools/ directories
#475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From here it looks all fine and the structure makes sense to me. You've changed the relevant spots where paths needed adjustment already 👍🏻 |
|
Thanks for the feedback! I'm currently figuring out what I need to change to make the "file not found" error go away, then this is ready for merging. |
This has a few advantages: 1. There's less visual noise in the top folder, making it easier to become familiar. 2. It becomes more obvious, which of the folders contain Fornjot crates, as opposed to other crates that are not relevant outside of this repository. 3. It opens the door for further automation of the release process, by providing an easy way to detect all crates that should be published.
This has the following advantages: 1. It provides some implicit documentation on what release-operator is, making it easier to see at first glance what's relevant only inside this repository, and what's relevant to users. 2. It provides a place for adding more tools later, without creating a mess in the repository root.
|
Okay, turns out I moved the configuration file to |
This was referenced Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for justification. The reason I'm doing this now, is that I'm working on adding a second tool crate, as part of #54.
What do you think, @hendrikmaus? Since this affects release-operator and possibly the further automation of the relase process, both topics you've worked on exclusively, I'd love to get your input.