Dumb down ValidationError
#402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous structure was pretty neat, while this is decidedly not. What this new solution has going for it, is that it's dumb. This is good, because `ValidationError` will soon need to be able to represent validation errors from multiple sources, and making the previous smart `ValidationError` event smarter, soon enough runs into limitations of Rust's type system. This new dumb solution, on the other hand, effortlessly scales to the new requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently building some infrastructure to clean up tests, on my way towards addressing #105. I ran into a limitation with
ValidationError, which this solves.