Allow Triangles to carry a color and transfer that to the vertices du… #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
therealprof
force-pushed
the
color-level-up
branch
from
db5969a to
11fa29e
Compare
hannobraun
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
Thank you, @therealprof!
I think adding the color to Triangle itself feels a bit icky, as color seems like a separate concern that the math types shouldn't have to care about. Nonetheless, this is a practical solution, and good enough for now (my favorite kind of good).
I'm going to merge it, especially since there's already a PR for adding coloring support based on it #343. We can clean this up later, if and when someone comes up with something better.
…ring meshing This moves the hardcoded color specification (still red with full opacity) one level closer to the actual model. Signed-off-by: Daniel Egger <[email protected]>
Signed-off-by: Daniel Egger <[email protected]>
hannobraun
force-pushed
the
color-level-up
branch
from
25a0e8a to
a76229c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ring meshing
This moves the hardcoded color specification (still red with full
opacity) one level closer to the actual model.
Signed-off-by: Daniel Egger [email protected]